--- projects/cms/source/util/uk/org/iscream/cms/util/XMLPacketMaker.java 2000/12/12 20:44:30 1.7 +++ projects/cms/source/util/uk/org/iscream/cms/util/XMLPacketMaker.java 2001/03/01 16:55:11 1.10 @@ -10,13 +10,11 @@ import javax.xml.parsers.SAXParserFactory; import javax.xml.parsers.ParserConfigurationException; import javax.xml.parsers.SAXParser; -import uk.ac.ukc.iscream.core.*; - /** * XMLPacketMaker - Creates an XMLPacket object. * - * @author $Author: ajm $ - * @version $Id: XMLPacketMaker.java,v 1.7 2000/12/12 20:44:30 ajm Exp $ + * @author $Author: tdb $ + * @version $Id: XMLPacketMaker.java,v 1.10 2001/03/01 16:55:11 tdb Exp $ */ public class XMLPacketMaker extends HandlerBase { @@ -25,20 +23,31 @@ public class XMLPacketMaker extends HandlerBase { /** * The current CVS revision of this class */ - public final String REVISION = "$Revision: 1.7 $"; + public final String REVISION = "$Revision: 1.10 $"; //---STATIC METHODS--- //---CONSTRUCTORS--- - // Constructor for accepting XML input. + /** + * Constructor for accepting XML input. + * + * @param xml A String of XML to process. + */ public XMLPacketMaker (String xml) { _xml = xml; } //---PUBLIC METHODS--- - public XMLPacket createXMLPacket() { + /** + * Method to create an XML packet from the data this + * class was constructed with. + * + * @return an XMLPacket representing the XML String given + * @throws InvalidXMLException if the XML cannot be parsed + */ + public XMLPacket createXMLPacket() throws InvalidXMLException { // Create the XMLPacket to store values in. XMLPacket packet = new XMLPacket(); @@ -46,19 +55,16 @@ public class XMLPacketMaker extends HandlerBase { // Use the default (non-validating) parser SAXParserFactory factory = SAXParserFactory.newInstance(); try { - // Parse the input InputSource inputSource = new InputSource(new StringReader(_xml)); SAXParser saxParser = factory.newSAXParser(); saxParser.parse(inputSource, new XMLStringParser(packet)); - } catch (Exception e) { - _logger.write(this.toString(), Logger.WARNING, e.toString()); - _logger.write(this.toString(), Logger.WARNING, "An invalid XML UDP packet has been detected: "+packet.printAll()); - return null; + // couldn't parse the XML for some reason + throw new InvalidXMLException("Could not parse the XML: "+_xml); } - + // parsed successfully, return the packet return packet; } @@ -88,12 +94,6 @@ public class XMLPacketMaker extends HandlerBase { * Holds the xml */ String _xml; - - /** - * This holds a reference to the - * system logger that is being used. - */ - private Logger _logger = ReferenceManager.getInstance().getLogger(); /** * This is the friendly identifier of the