--- projects/cms/source/util/uk/org/iscream/cms/util/XMLPacketMaker.java	2000/11/30 02:04:18	1.4
+++ projects/cms/source/util/uk/org/iscream/cms/util/XMLPacketMaker.java	2001/03/10 00:49:39	1.11
@@ -1,64 +1,80 @@
 //---PACKAGE DECLARATION---
-package uk.ac.ukc.iscream.xml;
+package uk.ac.ukc.iscream.util;
 
 //---IMPORTS---
 import java.io.*;
 import java.util.ArrayList;
 
 import org.xml.sax.*;
+import org.xml.sax.helpers.*;
 import javax.xml.parsers.SAXParserFactory;
 import javax.xml.parsers.ParserConfigurationException;
 import javax.xml.parsers.SAXParser;
 
-import uk.ac.ukc.iscream.core.*;
-import uk.ac.ukc.iscream.refman.*;
-
 /**
  * XMLPacketMaker - Creates an XMLPacket object.
  *
  * @author  $Author: tdb $
- * @version $Id: XMLPacketMaker.java,v 1.4 2000/11/30 02:04:18 tdb Exp $
+ * @version $Id: XMLPacketMaker.java,v 1.11 2001/03/10 00:49:39 tdb Exp $
  */
-public class XMLPacketMaker extends HandlerBase {
+public class XMLPacketMaker {
 
 //---FINAL ATTRIBUTES---
 
     /**
      * The current CVS revision of this class
      */
-    public final String REVISION = "$Revision: 1.4 $";
+    public final String REVISION = "$Revision: 1.11 $";
     
+    /**
+     * A static reference to the system saxParser
+     * Use the default (non-validating) parser
+     */
+    private static SAXParser saxParser = null;
+    private static SAXParserFactory factory = SAXParserFactory.newInstance();
+     
 //---STATIC METHODS---
 
 //---CONSTRUCTORS---
 
-    // Constructor for accepting XML input.
+    /**
+     * Constructor for accepting XML input.
+     *
+     * @param xml A String of XML to process.
+     */
     public XMLPacketMaker (String xml) {
         _xml = xml;
     }
 
 //---PUBLIC METHODS---
 
-    public XMLPacket createXMLPacket() {
+    /**
+     * Method to create an XML packet from the data this
+     * class was constructed with.
+     *
+     * @return an XMLPacket representing the XML String given
+     * @throws InvalidXMLException if the XML cannot be parsed
+     */
+    public XMLPacket createXMLPacket() throws InvalidXMLException {
 
         // Create the XMLPacket to store values in.
         XMLPacket packet = new XMLPacket();
-
-        // Use the default (non-validating) parser
-        SAXParserFactory factory = SAXParserFactory.newInstance();
+        
         try {
-
             // Parse the input
             InputSource inputSource = new InputSource(new StringReader(_xml));
-            SAXParser saxParser = factory.newSAXParser();
+            
+            if (saxParser == null) {
+                saxParser = factory.newSAXParser();
+            }
+            
             saxParser.parse(inputSource, new XMLStringParser(packet));
-
         }
         catch (Exception e) {
-            _logger.write(this.toString(), Logger.WARNING, "An invalid XML UDP packet has been detected: "+packet.printAll());
-            return null;
+            // couldn't parse the XML for some reason
+            throw new InvalidXMLException("Could not parse the XML: "+_xml);
         }
-        
+        // parsed successfully, return the packet
         return packet;
     }
 
@@ -66,10 +82,16 @@ public class XMLPacketMaker extends HandlerBase {
      * Overrides the {@link java.lang.Object#toString() Object.toString()}
      * method to provide clean logging (every class should have this).
      *
+     * This uses the uk.ac.ukc.iscream.util.NameFormat class
+     * to format the toString()
+     *
      * @return the name of this class and its CVS revision
      */
     public String toString() {
-        return this.getClass().getName() + "(" + REVISION.substring(11, REVISION.length() - 2) + ")";
+        return FormatName.getName(
+            _name,
+            getClass().getName(),
+            REVISION);
     }
 
 //---PRIVATE METHODS---
@@ -78,8 +100,21 @@ public class XMLPacketMaker extends HandlerBase {
 
 //---ATTRIBUTES---
 
+    /**
+     * Holds the xml
+     */
     String _xml;
-    Logger _logger = ReferenceManager.getInstance().getLogger();
+    
+    /**
+     * This is the friendly identifier of the
+     * component this class is running in.
+     * eg, a Filter may be called "filter1",
+     * If this class does not have an owning
+     * component,  a name from the configuration
+     * can be placed here.  This name could also
+     * be changed to null for utility classes.
+     */
+    private String _name = null;
 
 //---STATIC ATTRIBUTES---