ViewVC Help

View File | Revision Log | Show Annotations | Revision Graph | Root Listing

root/i-scream/projects/libstatgrab/src/libstatgrab/disk_stats.c

Comparing projects/libstatgrab/src/libstatgrab/disk_stats.c (file contents):
Revision 1.53 by tdb, Mon Feb 16 14:55:32 2004 UTC vs.
Revision 1.72 by ats, Sun Jul 18 21:30:11 2004 UTC

#	Line 1 | Line 1
1		/*
2	<	* i-scream central monitoring system
2	>	* i-scream libstatgrab
3		* http://www.i-scream.org
4		* Copyright (C) 2000-2004 i-scream
5		*
#	Line 30 | Line 30
30		#include <string.h>
31		#include <time.h>
32		#include "statgrab.h"
33	+	#include "vector.h"
34	+	#include "tools.h"
35
36		#ifdef SOLARIS
37		#include <sys/mnttab.h>
38		#include <sys/statvfs.h>
39		#include <kstat.h>
40	<	#define VALID_FS_TYPES {"ufs", "tmpfs"}
40	>	#define VALID_FS_TYPES {"ufs", "tmpfs", "vxfs"}
41		#endif
42
43		#if defined(LINUX) || defined(CYGWIN)
44		#include <mntent.h>
45		#include <sys/vfs.h>
44	–	#include "tools.h"
46		#endif
47
48		#ifdef LINUX
49		#define VALID_FS_TYPES {"adfs", "affs", "befs", "bfs", "efs", "ext2", \
50	<	"ext3", "vxfs", "hfs", "hfsplus", "hpfs", "jffs", \
51	<	"jffs2", "minix", "msdos", "ntfs", "qnx4", "ramfs", \
52	<	"rootfs", "reiserfs", "sysv", "v7", "udf", "ufs", \
53	<	"umsdos", "vfat", "xfs", "jfs"}
50	>	"ext3", "vxfs", "hfs", "hfsplus", "hpfs", "jffs", \
51	>	"jffs2", "minix", "msdos", "ntfs", "qnx4", "ramfs", \
52	>	"rootfs", "reiserfs", "sysv", "v7", "udf", "ufs", \
53	>	"umsdos", "vfat", "xfs", "jfs"}
54		#endif
55
56		#ifdef CYGWIN
#	Line 65 | Line 66
66		#include <sys/dkstat.h>
67		#include <devstat.h>
68		#define VALID_FS_TYPES {"hpfs", "msdosfs", "ntfs", "udf", "ext2fs", \
69	<	"ufs", "mfs"}
69	>	"ufs", "mfs"}
70		#endif
71		#if defined(NETBSD) || defined(OPENBSD)
72		#include <sys/param.h>
73		#include <sys/sysctl.h>
74		#include <sys/disk.h>
75		#define VALID_FS_TYPES {"ffs", "mfs", "msdos", "lfs", "adosfs", "ext2fs", \
76	<	"ntfs"}
76	>	"ntfs"}
77		#endif
78
79	<	#define START_VAL 1
80	<
81	<	char *copy_string(char *orig_ptr, const char *newtext){
82	<
82	<	/* Maybe free if not NULL, and strdup rather than realloc and strcpy? */
83	<	orig_ptr=realloc(orig_ptr, (1+strlen(newtext)));
84	<	if(orig_ptr==NULL){
85	<	return NULL;
86	<	}
87	<	strcpy(orig_ptr, newtext);
88	<
89	<	return orig_ptr;
79	>	static void disk_stat_init(sg_fs_stats *d) {
80	>	d->device_name = NULL;
81	>	d->fs_type = NULL;
82	>	d->mnt_point = NULL;
83		}
84
85	<
86	<	void init_disk_stat(int start, int end, disk_stat_t *disk_stats){
87	<
88	<	for(disk_stats+=start; start<=end; start++){
96	<	disk_stats->device_name=NULL;
97	<	disk_stats->fs_type=NULL;
98	<	disk_stats->mnt_point=NULL;
99	<
100	<	disk_stats++;
101	<	}
85	>	static void disk_stat_destroy(sg_fs_stats *d) {
86	>	free(d->device_name);
87	>	free(d->fs_type);
88	>	free(d->mnt_point);
89		}
90
91	<	int is_valid_fs_type(const char *type) {
91	>	static int is_valid_fs_type(const char *type) {
92		const char *types[] = VALID_FS_TYPES;
93		int i;
94
#	Line 113 | Line 100 | int is_valid_fs_type(const char *type) {
100		return 0;
101		}
102
103	<	disk_stat_t *get_disk_stats(int *entries){
103	>	sg_fs_stats *sg_get_fs_stats(int *entries){
104	>	VECTOR_DECLARE_STATIC(disk_stats, sg_fs_stats, 10,
105	>	disk_stat_init, disk_stat_destroy);
106
118	–	static disk_stat_t *disk_stats;
119	–	static int watermark=-1;
120	–
107		int valid_type;
108		int num_disks=0;
109		#if defined(LINUX) || defined (SOLARIS) || defined(CYGWIN)
110		FILE *f;
111		#endif
112
113	<	disk_stat_t *disk_ptr;
113	>	sg_fs_stats *disk_ptr;
114
115		#ifdef SOLARIS
116		struct mnttab mp;
#	Line 136 | Line 122 | disk_stat_t *get_disk_stats(int *entries){
122		#endif
123		#ifdef ALLBSD
124		int nummnt;
125	+	#ifdef HAVE_STATVFS
126	+	struct statvfs *mp;
127	+	#else
128		struct statfs *mp;
129		#endif
130	+	#endif
131
142	–	if(watermark==-1){
143	–	disk_stats=malloc(START_VAL * sizeof(disk_stat_t));
144	–	if(disk_stats==NULL){
145	–	return NULL;
146	–	}
147	–	watermark=START_VAL;
148	–	init_disk_stat(0, watermark-1, disk_stats);
149	–	}
132		#ifdef ALLBSD
133		nummnt=getmntinfo(&mp , MNT_LOCAL);
134		if (nummnt<=0){
135	+	sg_set_error_with_errno(SG_ERROR_GETMNTINFO, NULL);
136		return NULL;
137		}
138		for(;nummnt--; mp++){
#	Line 158 | Line 141 | disk_stat_t *get_disk_stats(int *entries){
141
142		#if defined(LINUX) || defined(CYGWIN)
143		if ((f=setmntent("/etc/mtab", "r" ))==NULL){
144	+	sg_set_error(SG_ERROR_SETMNTENT, NULL);
145		return NULL;
146		}
147
#	Line 171 | Line 155 | disk_stat_t *get_disk_stats(int *entries){
155
156		#ifdef SOLARIS
157		if ((f=fopen("/etc/mnttab", "r" ))==NULL){
158	+	sg_set_error_with_errno(SG_ERROR_OPEN, "/etc/mnttab");
159		return NULL;
160		}
161		while((getmntent(f, &mp)) == 0){
#	Line 181 | Line 166 | disk_stat_t *get_disk_stats(int *entries){
166		#endif
167
168		if(valid_type){
169	<	if(num_disks>watermark-1){
170	<	disk_ptr=disk_stats;
186	<	if((disk_stats=realloc(disk_stats, (watermark*2 * sizeof(disk_stat_t))))==NULL){
187	<	disk_stats=disk_ptr;
188	<	return NULL;
189	<	}
190	<
191	<	watermark=watermark*2;
192	<	init_disk_stat(num_disks, watermark-1, disk_stats);
169	>	if (VECTOR_RESIZE(disk_stats, num_disks + 1) < 0) {
170	>	return NULL;
171		}
194	–
172		disk_ptr=disk_stats+num_disks;
173	+
174		#ifdef ALLBSD
175	<	if((disk_ptr->device_name=copy_string(disk_ptr->device_name, mp->f_mntfromname))==NULL){
175	>	if (sg_update_string(&disk_ptr->device_name, mp->f_mntfromname) < 0) {
176		return NULL;
177		}
178	<
201	<	if((disk_ptr->fs_type=copy_string(disk_ptr->fs_type, mp->f_fstypename))==NULL){
178	>	if (sg_update_string(&disk_ptr->fs_type, mp->f_fstypename) < 0) {
179		return NULL;
180		}
181	<
205	<	if((disk_ptr->mnt_point=copy_string(disk_ptr->mnt_point, mp->f_mntonname))==NULL){
181	>	if (sg_update_string(&disk_ptr->mnt_point, mp->f_mntonname) < 0) {
182		return NULL;
183		}
184
#	Line 216 | Line 192 | disk_stat_t *get_disk_stats(int *entries){
192		disk_ptr->used_inodes=disk_ptr->total_inodes-disk_ptr->free_inodes;
193		#endif
194		#if defined(LINUX) || defined(CYGWIN)
195	<	if((disk_ptr->device_name=copy_string(disk_ptr->device_name, mp->mnt_fsname))==NULL){
195	>	if (sg_update_string(&disk_ptr->device_name, mp->mnt_fsname) < 0) {
196		return NULL;
197		}
198
199	<	if((disk_ptr->fs_type=copy_string(disk_ptr->fs_type, mp->mnt_type))==NULL){
199	>	if (sg_update_string(&disk_ptr->fs_type, mp->mnt_type) < 0) {
200		return NULL;
201		}
202
203	<	if((disk_ptr->mnt_point=copy_string(disk_ptr->mnt_point, mp->mnt_dir))==NULL){
203	>	if (sg_update_string(&disk_ptr->mnt_point, mp->mnt_dir) < 0) {
204		return NULL;
205		}
206		disk_ptr->size = (long long)fs.f_bsize * (long long)fs.f_blocks;
#	Line 238 | Line 214 | disk_stat_t *get_disk_stats(int *entries){
214		#endif
215
216		#ifdef SOLARIS
241	–	/* Memory leak in event of realloc failing */
217		/* Maybe make this char[bigenough] and do strncpy's and put a null in the end?
218		* Downside is its a bit hungry for a lot of mounts, as MNT_MAX_SIZE would prob
219		* be upwards of a k each
220		*/
221	<	if((disk_ptr->device_name=copy_string(disk_ptr->device_name, mp.mnt_special))==NULL){
221	>	if (sg_update_string(&disk_ptr->device_name, mp.mnt_special) < 0) {
222		return NULL;
223		}
224
225	<	if((disk_ptr->fs_type=copy_string(disk_ptr->fs_type, mp.mnt_fstype))==NULL){
226	<	return NULL;
227	<	}
225	>	if (sg_update_string(&disk_ptr->fs_type, mp.mnt_fstype) < 0) {
226	>	return NULL;
227	>	}
228
229	<	if((disk_ptr->mnt_point=copy_string(disk_ptr->mnt_point, mp.mnt_mountp))==NULL){
230	<	return NULL;
231	<	}
229	>	if (sg_update_string(&disk_ptr->mnt_point, mp.mnt_mountp) < 0) {
230	>	return NULL;
231	>	}
232
233		disk_ptr->size = (long long)fs.f_frsize * (long long)fs.f_blocks;
234		disk_ptr->avail = (long long)fs.f_frsize * (long long)fs.f_bavail;
#	Line 270 | Line 245 | disk_stat_t *get_disk_stats(int *entries){
245		*entries=num_disks;
246
247		/* If this fails, there is very little i can do about it, so
248	<	I'll ignore it :) */
248	>	I'll ignore it :) */
249		#if defined(LINUX) || defined(CYGWIN)
250		endmntent(f);
251		#endif
#	Line 281 | Line 256 | disk_stat_t *get_disk_stats(int *entries){
256		return disk_stats;
257
258		}
284	–	void diskio_stat_init(int start, int end, diskio_stat_t *diskio_stats){
259
260	<	for(diskio_stats+=start; start<end; start++){
261	<	diskio_stats->disk_name=NULL;
262	<
263	<	diskio_stats++;
264	<	}
260	>	int sg_fs_compare_device_name(const void *va, const void *vb) {
261	>	const sg_fs_stats *a = (const sg_fs_stats *)va;
262	>	const sg_fs_stats *b = (const sg_fs_stats *)vb;
263	>
264	>	return strcmp(a->device_name, b->device_name);
265		}
266
267	<	diskio_stat_t *diskio_stat_malloc(int needed_entries, int *cur_entries, diskio_stat_t *diskio_stats){
267	>	int sg_fs_compare_mnt_point(const void *va, const void *vb) {
268	>	const sg_fs_stats *a = (const sg_fs_stats *)va;
269	>	const sg_fs_stats *b = (const sg_fs_stats *)vb;
270
271	<	if(diskio_stats==NULL){
271	>	return strcmp(a->mnt_point, b->mnt_point);
272	>	}
273
274	<	if((diskio_stats=malloc(needed_entries * sizeof(diskio_stat_t)))==NULL){
275	<	return NULL;
276	<	}
300	<	diskio_stat_init(0, needed_entries, diskio_stats);
301	<	*cur_entries=needed_entries;
274	>	static void diskio_stat_init(sg_disk_io_stats *d) {
275	>	d->disk_name = NULL;
276	>	}
277
278	<	return diskio_stats;
279	<	}
305	<
306	<
307	<	if(*cur_entries<needed_entries){
308	<	diskio_stats=realloc(diskio_stats, (sizeof(diskio_stat_t)*needed_entries));
309	<	if(diskio_stats==NULL){
310	<	return NULL;
311	<	}
312	<	diskio_stat_init(*cur_entries, needed_entries, diskio_stats);
313	<	*cur_entries=needed_entries;
314	<	}
315	<
316	<	return diskio_stats;
278	>	static void diskio_stat_destroy(sg_disk_io_stats *d) {
279	>	free(d->disk_name);
280		}
281
282	<	static diskio_stat_t *diskio_stats=NULL;
283	<	static int num_diskio=0;
282	>	VECTOR_DECLARE_STATIC(diskio_stats, sg_disk_io_stats, 10,
283	>	diskio_stat_init, diskio_stat_destroy);
284
285		#ifdef LINUX
286		typedef struct {
#	Line 326 | Line 289 | typedef struct {
289		} partition;
290		#endif
291
292	<	diskio_stat_t *get_diskio_stats(int *entries){
293	<
331	<	static int sizeof_diskio_stats=0;
292	>	sg_disk_io_stats *sg_get_disk_io_stats(int *entries){
293	>	int num_diskio;
294		#ifndef LINUX
295	<	diskio_stat_t *diskio_stats_ptr;
295	>	sg_disk_io_stats *diskio_stats_ptr;
296		#endif
297
298		#ifdef SOLARIS
299	<	kstat_ctl_t *kc;
300	<	kstat_t *ksp;
299	>	kstat_ctl_t *kc;
300	>	kstat_t *ksp;
301		kstat_io_t kios;
302		#endif
303		#ifdef LINUX
#	Line 343 | Line 305 | diskio_stat_t *get_diskio_stats(int *entries){
305		char *line_ptr;
306		int major, minor;
307		int has_pp_stats = 1;
308	<	static partition *parts = NULL;
347	<	static int alloc_parts = 0;
308	>	VECTOR_DECLARE_STATIC(parts, partition, 16, NULL, NULL);
309		int i, n;
310		time_t now;
311		const char *format;
#	Line 387 | Line 348 | diskio_stat_t *get_diskio_stats(int *entries){
348
349		size = sizeof(diskcount);
350		if (sysctl(mib, MIBSIZE, &diskcount, &size, NULL, 0) < 0) {
351	+	sg_set_error_with_errno(SG_ERROR_SYSCTL, "CTL_HW.HW_DISKCOUNT");
352		return NULL;
353		}
354
#	Line 394 | Line 356 | diskio_stat_t *get_diskio_stats(int *entries){
356		mib[1] = HW_DISKNAMES;
357
358		if (sysctl(mib, MIBSIZE, NULL, &size, NULL, 0) < 0) {
359	+	sg_set_error_with_errno(SG_ERROR_SYSCTL, "CTL_HW.HW_DISKNAMES");
360		return NULL;
361		}
362
363	<	disknames = malloc(size);
363	>	disknames = sg_malloc(size);
364		if (disknames == NULL) {
365		return NULL;
366		}
367
368		if (sysctl(mib, MIBSIZE, disknames, &size, NULL, 0) < 0) {
369	+	sg_set_error_with_errno(SG_ERROR_SYSCTL, "CTL_HW.HW_DISKNAMES");
370		return NULL;
371		}
372
373	<	dk_name = calloc(diskcount, sizeof(char *));
373	>	dk_name = sg_malloc(diskcount * sizeof(char *));
374		bufpp = disknames;
375		for (i = 0; i < diskcount && (name = strsep(&bufpp, ",")) != NULL; i++) {
376		dk_name[i] = name;
#	Line 421 | Line 385 | diskio_stat_t *get_diskio_stats(int *entries){
385		#endif
386
387		if (sysctl(mib, MIBSIZE, NULL, &size, NULL, 0) < 0) {
388	+	sg_set_error_with_errno(SG_ERROR_SYSCTL, "CTL_HW.HW_DISKSTATS");
389		return NULL;
390		}
391
#	Line 430 | Line 395 | diskio_stat_t *get_diskio_stats(int *entries){
395		num_disks = size / sizeof(struct diskstats);
396		#endif
397
398	<	stats = malloc(size);
398	>	stats = sg_malloc(size);
399		if (stats == NULL) {
400		return NULL;
401		}
402
403		if (sysctl(mib, MIBSIZE, stats, &size, NULL, 0) < 0) {
404	+	sg_set_error_with_errno(SG_ERROR_SYSCTL, "CTL_HW.HW_DISKSTATS");
405		return NULL;
406		}
407
408		for (i = 0; i < num_disks; i++) {
409	+	const char *name;
410		u_int64_t rbytes, wbytes;
411
412		#ifdef NETBSD
#	Line 447 | Line 414 | diskio_stat_t *get_diskio_stats(int *entries){
414		rbytes = stats[i].dk_rbytes;
415		wbytes = stats[i].dk_wbytes;
416		#else
417	<	/* Before 1.7, NetBSD merged reads and writes. */
417	>	/* Before 2.0, NetBSD merged reads and writes. */
418		rbytes = wbytes = stats[i].dk_bytes;
419		#endif
420		#else
421	+	#ifdef HAVE_DS_RBYTES
422	+	rbytes = stats[i].ds_rbytes;
423	+	wbytes = stats[i].ds_wbytes;
424	+	#else
425	+	/* Before 3.5, OpenBSD merged reads and writes */
426		rbytes = wbytes = stats[i].ds_bytes;
427		#endif
428	+	#endif
429
430		/* Don't keep stats for disks that have never been used. */
431		if (rbytes == 0 && wbytes == 0) {
432		continue;
433		}
434
435	<	diskio_stats = diskio_stat_malloc(num_diskio + 1,
463	<	&sizeof_diskio_stats,
464	<	diskio_stats);
465	<	if (diskio_stats == NULL) {
435	>	if (VECTOR_RESIZE(diskio_stats, num_diskio + 1) < 0) {
436		return NULL;
437		}
438		diskio_stats_ptr = diskio_stats + num_diskio;
439
440		diskio_stats_ptr->read_bytes = rbytes;
441		diskio_stats_ptr->write_bytes = wbytes;
472	–	if (diskio_stats_ptr->disk_name != NULL) {
473	–	free(diskio_stats_ptr->disk_name);
474	–	}
442		#ifdef NETBSD
443	<	diskio_stats_ptr->disk_name = strdup(stats[i].dk_name);
443	>	name = stats[i].dk_name;
444		#else
445	<	diskio_stats_ptr->disk_name = strdup(dk_name[i]);
445	>	name = dk_name[i];
446		#endif
447	+	if (sg_update_string(&diskio_stats_ptr->disk_name, name) < 0) {
448	+	return NULL;
449	+	}
450		diskio_stats_ptr->systime = time(NULL);
451
452		num_diskio++;
#	Line 491 | Line 461 | diskio_stat_t *get_diskio_stats(int *entries){
461
462		#if defined(FREEBSD) || defined(DFBSD)
463		if (!stats_init) {
464	<	stats.dinfo=malloc(sizeof(struct devinfo));
464	>	stats.dinfo=sg_malloc(sizeof(struct devinfo));
465		if(stats.dinfo==NULL) return NULL;
466		bzero(stats.dinfo, sizeof(struct devinfo));
467		stats_init = 1;
468		}
469		#ifdef FREEBSD5
470	<	if ((devstat_getdevs(NULL, &stats)) < 0) return NULL;
470	>	if ((devstat_getdevs(NULL, &stats)) < 0) {
471	>	/* FIXME devstat functions return a string error in
472	>	devstat_errbuf */
473	>	sg_set_error(SG_ERROR_DEVSTAT_GETDEVS, NULL);
474	>	return NULL;
475	>	}
476		/* Not aware of a get all devices, so i said 999. If we ever
477		* find a machine with more than 999 disks, then i'll change
478		* this number :)
479		*/
480	<	if (devstat_selectdevs(&dev_sel, &n_selected, &n_selections, &sel_gen, stats.dinfo->generation, stats.dinfo->devices, stats.dinfo->numdevs, NULL, 0, NULL, 0, DS_SELECT_ONLY, 999, 1) < 0) return NULL;
480	>	if (devstat_selectdevs(&dev_sel, &n_selected, &n_selections, &sel_gen, stats.dinfo->generation, stats.dinfo->devices, stats.dinfo->numdevs, NULL, 0, NULL, 0, DS_SELECT_ONLY, 999, 1) < 0) {
481	>	sg_set_error(SG_ERROR_DEVSTAT_SELECTDEVS, NULL);
482	>	return NULL;
483	>	}
484		#else
485	<	if ((getdevs(&stats)) < 0) return NULL;
485	>	if ((getdevs(&stats)) < 0) {
486	>	sg_set_error(SG_ERROR_DEVSTAT_GETDEVS, NULL);
487	>	return NULL;
488	>	}
489		/* Not aware of a get all devices, so i said 999. If we ever
490		* find a machine with more than 999 disks, then i'll change
491		* this number :)
492		*/
493	<	if (selectdevs(&dev_sel, &n_selected, &n_selections, &sel_gen, stats.dinfo->generation, stats.dinfo->devices, stats.dinfo->numdevs, NULL, 0, NULL, 0, DS_SELECT_ONLY, 999, 1) < 0) return NULL;
493	>	if (selectdevs(&dev_sel, &n_selected, &n_selections, &sel_gen, stats.dinfo->generation, stats.dinfo->devices, stats.dinfo->numdevs, NULL, 0, NULL, 0, DS_SELECT_ONLY, 999, 1) < 0) {
494	>	sg_set_error(SG_ERROR_DEVSTAT_SELECTDEVS, NULL);
495	>	return NULL;
496	>	}
497		#endif
498
499		for(counter=0;counter<stats.dinfo->numdevs;counter++){
#	Line 524 | Line 508 | diskio_stat_t *get_diskio_stats(int *entries){
508		#else
509		if((dev_ptr->bytes_read==0) && (dev_ptr->bytes_written==0)) continue;
510		#endif
511	<	if((diskio_stats=diskio_stat_malloc(num_diskio+1, &sizeof_diskio_stats, diskio_stats))==NULL){
511	>
512	>	if (VECTOR_RESIZE(diskio_stats, num_diskio + 1) < 0) {
513		return NULL;
514		}
515		diskio_stats_ptr=diskio_stats+num_diskio;
#	Line 537 | Line 522 | diskio_stat_t *get_diskio_stats(int *entries){
522		diskio_stats_ptr->write_bytes=dev_ptr->bytes_written;
523		#endif
524		if(diskio_stats_ptr->disk_name!=NULL) free(diskio_stats_ptr->disk_name);
525	<	asprintf((&diskio_stats_ptr->disk_name), "%s%d", dev_ptr->device_name, dev_ptr->unit_number);
525	>	if (asprintf((&diskio_stats_ptr->disk_name), "%s%d", dev_ptr->device_name, dev_ptr->unit_number) == -1) {
526	>	sg_set_error_with_errno(SG_ERROR_ASPRINTF, NULL);
527	>	return NULL;
528	>	}
529		diskio_stats_ptr->systime=time(NULL);
530
531		num_diskio++;
#	Line 547 | Line 535 | diskio_stat_t *get_diskio_stats(int *entries){
535		#endif
536		#ifdef SOLARIS
537		if ((kc = kstat_open()) == NULL) {
538	<	return NULL;
539	<	}
538	>	sg_set_error(SG_ERROR_KSTAT_OPEN, NULL);
539	>	return NULL;
540	>	}
541
542		for (ksp = kc->kc_chain; ksp; ksp = ksp->ks_next) {
543	<	if (!strcmp(ksp->ks_class, "disk")) {
543	>	if (!strcmp(ksp->ks_class, "disk")) {
544
545		if(ksp->ks_type != KSTAT_TYPE_IO) continue;
546		/* We dont want metadevices appearins as num_diskio */
547		if(strcmp(ksp->ks_module, "md")==0) continue;
548	<	if((kstat_read(kc, ksp, &kios))==-1){
548	>	if((kstat_read(kc, ksp, &kios))==-1){
549		}
550
551	<	if((diskio_stats=diskio_stat_malloc(num_diskio+1, &sizeof_diskio_stats, diskio_stats))==NULL){
551	>	if (VECTOR_RESIZE(diskio_stats, num_diskio + 1) < 0) {
552		kstat_close(kc);
553		return NULL;
554		}
555		diskio_stats_ptr=diskio_stats+num_diskio;
556
557		diskio_stats_ptr->read_bytes=kios.nread;
569	–
558		diskio_stats_ptr->write_bytes=kios.nwritten;
559	<
560	<	if(diskio_stats_ptr->disk_name!=NULL) free(diskio_stats_ptr->disk_name);
561	<
562	<	diskio_stats_ptr->disk_name=strdup((char *) get_svr_from_bsd(ksp->ks_name));
559	>	if (sg_update_string(&diskio_stats_ptr->disk_name,
560	>	sg_get_svr_from_bsd(ksp->ks_name)) < 0) {
561	>	return NULL;
562	>	}
563		diskio_stats_ptr->systime=time(NULL);
564	+
565		num_diskio++;
566		}
567		}
#	Line 590 | Line 579 | diskio_stat_t *get_diskio_stats(int *entries){
579		the same format. */
580
581		f = fopen("/proc/diskstats", "r");
582	<	format = " %d %d %19s %*d %*d %lld %*d %*d %*d %lld";
582	>	format = " %d %d %99s %*d %*d %lld %*d %*d %*d %lld";
583		if (f == NULL) {
584		f = fopen("/proc/partitions", "r");
585	<	format = " %d %d %*d %19s %*d %*d %lld %*d %*d %*d %lld";
585	>	format = " %d %d %*d %99s %*d %*d %lld %*d %*d %*d %lld";
586		}
587		if (f == NULL) goto out;
588		now = time(NULL);
589
590	<	while ((line_ptr = f_read_line(f, "")) != NULL) {
591	<	char name[20];
590	>	while ((line_ptr = sg_f_read_line(f, "")) != NULL) {
591	>	char name[100];
592		char *s;
593		long long rsect, wsect;
594
#	Line 620 | Line 609 | diskio_stat_t *get_diskio_stats(int *entries){
609		wsect = 0;
610		}
611
612	<	diskio_stats = diskio_stat_malloc(n + 1, &sizeof_diskio_stats,
613	<	diskio_stats);
625	<	if (diskio_stats == NULL) goto out;
626	<	if (n >= alloc_parts) {
627	<	alloc_parts += 16;
628	<	parts = realloc(parts, alloc_parts * sizeof *parts);
629	<	if (parts == NULL) {
630	<	alloc_parts = 0;
631	<	goto out;
632	<	}
612	>	if (VECTOR_RESIZE(diskio_stats, n + 1) < 0) {
613	>	goto out;
614		}
615	+	if (VECTOR_RESIZE(parts, n + 1) < 0) {
616	+	goto out;
617	+	}
618
619	<	if (diskio_stats[n].disk_name != NULL)
620	<	free(diskio_stats[n].disk_name);
621	<	diskio_stats[n].disk_name = strdup(name);
619	>	if (sg_update_string(&diskio_stats[n].disk_name, name) < 0) {
620	>	goto out;
621	>	}
622		diskio_stats[n].read_bytes = rsect * 512;
623		diskio_stats[n].write_bytes = wsect * 512;
624		diskio_stats[n].systime = now;
#	Line 656 | Line 640 | diskio_stat_t *get_diskio_stats(int *entries){
640		if (f == NULL) goto out;
641		now = time(NULL);
642
643	<	line_ptr = f_read_line(f, "disk_io:");
643	>	line_ptr = sg_f_read_line(f, "disk_io:");
644		if (line_ptr == NULL) goto out;
645
646		while((line_ptr=strchr(line_ptr, ' '))!=NULL){
#	Line 720 | Line 704 | out:
704		#endif
705
706		#ifdef CYGWIN
707	+	sg_set_error(SG_ERROR_UNSUPPORTED, "Cygwin");
708		return NULL;
709		#endif
710
#	Line 728 | Line 713 | out:
713		return diskio_stats;
714		}
715
716	<	diskio_stat_t *get_diskio_stats_diff(int *entries){
717	<	static diskio_stat_t *diff = NULL;
718	<	static int diff_count = 0;
719	<	diskio_stat_t *src, *dest;
720	<	int i, j, new_count;
716	>	sg_disk_io_stats *sg_get_disk_io_stats_diff(int *entries){
717	>	VECTOR_DECLARE_STATIC(diff, sg_disk_io_stats, 1,
718	>	diskio_stat_init, diskio_stat_destroy);
719	>	sg_disk_io_stats *src = NULL, *dest;
720	>	int i, j, diff_count, new_count;
721
722		if (diskio_stats == NULL) {
723		/* No previous stats, so we can't calculate a difference. */
724	<	return get_diskio_stats(entries);
724	>	return sg_get_disk_io_stats(entries);
725		}
726
727		/* Resize the results array to match the previous stats. */
728	<	diff = diskio_stat_malloc(num_diskio, &diff_count, diff);
729	<	if (diff == NULL) {
728	>	diff_count = VECTOR_SIZE(diskio_stats);
729	>	if (VECTOR_RESIZE(diff, diff_count) < 0) {
730		return NULL;
731		}
732
#	Line 750 | Line 735 | diskio_stat_t *get_diskio_stats_diff(int *entries){
735		src = &diskio_stats[i];
736		dest = &diff[i];
737
738	<	if (dest->disk_name != NULL) {
739	<	free(dest->disk_name);
738	>	if (sg_update_string(&dest->disk_name, src->disk_name) < 0) {
739	>	return NULL;
740		}
756	–	dest->disk_name = strdup(src->disk_name);
741		dest->read_bytes = src->read_bytes;
742		dest->write_bytes = src->write_bytes;
743		dest->systime = src->systime;
744		}
745
746		/* Get a new set of stats. */
747	<	if (get_diskio_stats(&new_count) == NULL) {
747	>	if (sg_get_disk_io_stats(&new_count) == NULL) {
748		return NULL;
749		}
750
#	Line 791 | Line 775 | diskio_stat_t *get_diskio_stats_diff(int *entries){
775
776		*entries = diff_count;
777		return diff;
778	+	}
779	+
780	+	int sg_disk_io_compare_name(const void *va, const void *vb) {
781	+	const sg_disk_io_stats *a = (const sg_disk_io_stats *)va;
782	+	const sg_disk_io_stats *b = (const sg_disk_io_stats *)vb;
783	+
784	+	return strcmp(a->disk_name, b->disk_name);
785		}
786

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines