ViewVC Help

View File | Revision Log | Show Annotations | Revision Graph | Root Listing

root/i-scream/projects/libstatgrab/src/libstatgrab/disk_stats.c

Comparing projects/libstatgrab/src/libstatgrab/disk_stats.c (file contents):
Revision 1.56 by ats, Sun Apr 4 22:18:38 2004 UTC vs.
Revision 1.79 by ats, Sun Nov 7 15:06:49 2004 UTC

#	Line 1 | Line 1
1		/*
2	<	* i-scream central monitoring system
2	>	* i-scream libstatgrab
3		* http://www.i-scream.org
4		* Copyright (C) 2000-2004 i-scream
5		*
#	Line 31 | Line 31
31		#include <time.h>
32		#include "statgrab.h"
33		#include "vector.h"
34	+	#include "tools.h"
35
36		#ifdef SOLARIS
37		#include <sys/mnttab.h>
38		#include <sys/statvfs.h>
39		#include <kstat.h>
40	<	#define VALID_FS_TYPES {"ufs", "tmpfs"}
40	>	#define VALID_FS_TYPES {"ufs", "tmpfs", "vxfs"}
41		#endif
42
43		#if defined(LINUX) || defined(CYGWIN)
44		#include <mntent.h>
45		#include <sys/vfs.h>
45	–	#include "tools.h"
46		#endif
47
48		#ifdef LINUX
49		#define VALID_FS_TYPES {"adfs", "affs", "befs", "bfs", "efs", "ext2", \
50	<	"ext3", "vxfs", "hfs", "hfsplus", "hpfs", "jffs", \
51	<	"jffs2", "minix", "msdos", "ntfs", "qnx4", "ramfs", \
52	<	"rootfs", "reiserfs", "sysv", "v7", "udf", "ufs", \
53	<	"umsdos", "vfat", "xfs", "jfs"}
50	>	"ext3", "vxfs", "hfs", "hfsplus", "hpfs", "jffs", \
51	>	"jffs2", "minix", "msdos", "ntfs", "qnx4", "ramfs", \
52	>	"rootfs", "reiserfs", "sysv", "v7", "udf", "ufs", \
53	>	"umsdos", "vfat", "xfs", "jfs"}
54		#endif
55
56		#ifdef CYGWIN
#	Line 66 | Line 66
66		#include <sys/dkstat.h>
67		#include <devstat.h>
68		#define VALID_FS_TYPES {"hpfs", "msdosfs", "ntfs", "udf", "ext2fs", \
69	<	"ufs", "mfs"}
69	>	"ufs", "mfs"}
70		#endif
71		#if defined(NETBSD) || defined(OPENBSD)
72		#include <sys/param.h>
73		#include <sys/sysctl.h>
74		#include <sys/disk.h>
75		#define VALID_FS_TYPES {"ffs", "mfs", "msdos", "lfs", "adosfs", "ext2fs", \
76	<	"ntfs"}
76	>	"ntfs"}
77		#endif
78
79	<	char *copy_string(char *orig_ptr, const char *newtext){
79	>	#ifdef HPUX
80	>	#include <sys/param.h>
81	>	#include <sys/pstat.h>
82	>	#include <sys/types.h>
83	>	#include <sys/stat.h>
84	>	#include <sys/vfs.h>
85	>	#include <mntent.h>
86	>	#include <dirent.h>
87	>	#include <stdio.h>
88	>	#include <time.h>
89	>	#define VALID_FS_TYPES {"vxfs", "hfs"}
90	>	#define DISK_BATCH 30
91	>	#endif
92
93	<	/* Maybe free if not NULL, and strdup rather than realloc and strcpy? */
82	<	orig_ptr=realloc(orig_ptr, (1+strlen(newtext)));
83	<	if(orig_ptr==NULL){
84	<	return NULL;
85	<	}
86	<	strcpy(orig_ptr, newtext);
87	<
88	<	return orig_ptr;
89	<	}
90	<
91	<	static void disk_stat_init(disk_stat_t *d) {
93	>	static void disk_stat_init(sg_fs_stats *d) {
94		d->device_name = NULL;
95		d->fs_type = NULL;
96		d->mnt_point = NULL;
97		}
98
99	<	static void disk_stat_destroy(disk_stat_t *d) {
99	>	static void disk_stat_destroy(sg_fs_stats *d) {
100		free(d->device_name);
101		free(d->fs_type);
102		free(d->mnt_point);
103		}
104
105	<	int is_valid_fs_type(const char *type) {
105	>	static int is_valid_fs_type(const char *type) {
106		const char *types[] = VALID_FS_TYPES;
107		int i;
108
109	<	for (i = 0; i < (sizeof types / sizeof *types); i++) {
109	>	for (i = 0; i < (int) (sizeof types / sizeof *types); i++) {
110		if (strcmp(types[i], type) == 0) {
111		return 1;
112		}
#	Line 112 | Line 114 | int is_valid_fs_type(const char *type) {
114		return 0;
115		}
116
117	<	disk_stat_t *get_disk_stats(int *entries){
118	<	VECTOR_DECLARE_STATIC(disk_stats, disk_stat_t, 10,
119	<	disk_stat_init, disk_stat_destroy);
117	>	sg_fs_stats *sg_get_fs_stats(int *entries){
118	>	VECTOR_DECLARE_STATIC(disk_stats, sg_fs_stats, 10,
119	>	disk_stat_init, disk_stat_destroy);
120
121		int valid_type;
122		int num_disks=0;
123	<	#if defined(LINUX) || defined (SOLARIS) || defined(CYGWIN)
123	>	#if defined(LINUX) || defined (SOLARIS) || defined(CYGWIN) || defined(HPUX)
124		FILE *f;
125		#endif
126
127	<	disk_stat_t *disk_ptr;
127	>	sg_fs_stats *disk_ptr;
128
129		#ifdef SOLARIS
130		struct mnttab mp;
131		struct statvfs fs;
132		#endif
133	<	#if defined(LINUX) || defined(CYGWIN)
133	>	#if defined(LINUX) || defined(CYGWIN) || defined(HPUX)
134		struct mntent *mp;
135		struct statfs fs;
136		#endif
137		#ifdef ALLBSD
138		int nummnt;
139	+	#ifdef HAVE_STATVFS
140	+	struct statvfs *mp;
141	+	#else
142		struct statfs *mp;
143		#endif
144	+	#endif
145
146		#ifdef ALLBSD
147		nummnt=getmntinfo(&mp , MNT_LOCAL);
148		if (nummnt<=0){
149	+	sg_set_error_with_errno(SG_ERROR_GETMNTINFO, NULL);
150		return NULL;
151		}
152		for(;nummnt--; mp++){
153		valid_type = is_valid_fs_type(mp->f_fstypename);
154		#endif
155
156	<	#if defined(LINUX) || defined(CYGWIN)
156	>	#if defined(LINUX) || defined(CYGWIN) || defined(HPUX)
157	>	#ifdef MNT_MNTTAB
158	>	if ((f=setmntent(MNT_MNTTAB, "r" ))==NULL){
159	>	#else
160		if ((f=setmntent("/etc/mtab", "r" ))==NULL){
161	+	#endif
162	+	sg_set_error(SG_ERROR_SETMNTENT, NULL);
163		return NULL;
164		}
165
#	Line 161 | Line 173 | disk_stat_t *get_disk_stats(int *entries){
173
174		#ifdef SOLARIS
175		if ((f=fopen("/etc/mnttab", "r" ))==NULL){
176	+	sg_set_error_with_errno(SG_ERROR_OPEN, "/etc/mnttab");
177		return NULL;
178		}
179		while((getmntent(f, &mp)) == 0){
#	Line 177 | Line 190 | disk_stat_t *get_disk_stats(int *entries){
190		disk_ptr=disk_stats+num_disks;
191
192		#ifdef ALLBSD
193	<	if((disk_ptr->device_name=copy_string(disk_ptr->device_name, mp->f_mntfromname))==NULL){
193	>	if (sg_update_string(&disk_ptr->device_name, mp->f_mntfromname) < 0) {
194		return NULL;
195		}
196	<
184	<	if((disk_ptr->fs_type=copy_string(disk_ptr->fs_type, mp->f_fstypename))==NULL){
196	>	if (sg_update_string(&disk_ptr->fs_type, mp->f_fstypename) < 0) {
197		return NULL;
198		}
199	<
188	<	if((disk_ptr->mnt_point=copy_string(disk_ptr->mnt_point, mp->f_mntonname))==NULL){
199	>	if (sg_update_string(&disk_ptr->mnt_point, mp->f_mntonname) < 0) {
200		return NULL;
201		}
202
#	Line 198 | Line 209 | disk_stat_t *get_disk_stats(int *entries){
209		/* Freebsd doesn't have a "available" inodes */
210		disk_ptr->used_inodes=disk_ptr->total_inodes-disk_ptr->free_inodes;
211		#endif
212	<	#if defined(LINUX) || defined(CYGWIN)
213	<	if((disk_ptr->device_name=copy_string(disk_ptr->device_name, mp->mnt_fsname))==NULL){
212	>	#if defined(LINUX) || defined(CYGWIN) || defined(HPUX)
213	>	if (sg_update_string(&disk_ptr->device_name, mp->mnt_fsname) < 0) {
214		return NULL;
215		}
216
217	<	if((disk_ptr->fs_type=copy_string(disk_ptr->fs_type, mp->mnt_type))==NULL){
217	>	if (sg_update_string(&disk_ptr->fs_type, mp->mnt_type) < 0) {
218		return NULL;
219		}
220
221	<	if((disk_ptr->mnt_point=copy_string(disk_ptr->mnt_point, mp->mnt_dir))==NULL){
221	>	if (sg_update_string(&disk_ptr->mnt_point, mp->mnt_dir) < 0) {
222		return NULL;
223		}
224		disk_ptr->size = (long long)fs.f_bsize * (long long)fs.f_blocks;
#	Line 221 | Line 232 | disk_stat_t *get_disk_stats(int *entries){
232		#endif
233
234		#ifdef SOLARIS
224	–	/* Memory leak in event of realloc failing */
235		/* Maybe make this char[bigenough] and do strncpy's and put a null in the end?
236		* Downside is its a bit hungry for a lot of mounts, as MNT_MAX_SIZE would prob
237		* be upwards of a k each
238		*/
239	<	if((disk_ptr->device_name=copy_string(disk_ptr->device_name, mp.mnt_special))==NULL){
239	>	if (sg_update_string(&disk_ptr->device_name, mp.mnt_special) < 0) {
240		return NULL;
241		}
242
243	<	if((disk_ptr->fs_type=copy_string(disk_ptr->fs_type, mp.mnt_fstype))==NULL){
244	<	return NULL;
245	<	}
243	>	if (sg_update_string(&disk_ptr->fs_type, mp.mnt_fstype) < 0) {
244	>	return NULL;
245	>	}
246
247	<	if((disk_ptr->mnt_point=copy_string(disk_ptr->mnt_point, mp.mnt_mountp))==NULL){
248	<	return NULL;
249	<	}
247	>	if (sg_update_string(&disk_ptr->mnt_point, mp.mnt_mountp) < 0) {
248	>	return NULL;
249	>	}
250
251		disk_ptr->size = (long long)fs.f_frsize * (long long)fs.f_blocks;
252		disk_ptr->avail = (long long)fs.f_frsize * (long long)fs.f_bavail;
#	Line 253 | Line 263 | disk_stat_t *get_disk_stats(int *entries){
263		*entries=num_disks;
264
265		/* If this fails, there is very little i can do about it, so
266	<	I'll ignore it :) */
267	<	#if defined(LINUX) || defined(CYGWIN)
266	>	I'll ignore it :) */
267	>	#if defined(LINUX) || defined(CYGWIN) || defined(HPUX)
268		endmntent(f);
269		#endif
270		#if defined(SOLARIS)
#	Line 265 | Line 275 | disk_stat_t *get_disk_stats(int *entries){
275
276		}
277
278	<	static void diskio_stat_init(diskio_stat_t *d) {
278	>	int sg_fs_compare_device_name(const void *va, const void *vb) {
279	>	const sg_fs_stats *a = (const sg_fs_stats *)va;
280	>	const sg_fs_stats *b = (const sg_fs_stats *)vb;
281	>
282	>	return strcmp(a->device_name, b->device_name);
283	>	}
284	>
285	>	int sg_fs_compare_mnt_point(const void *va, const void *vb) {
286	>	const sg_fs_stats *a = (const sg_fs_stats *)va;
287	>	const sg_fs_stats *b = (const sg_fs_stats *)vb;
288	>
289	>	return strcmp(a->mnt_point, b->mnt_point);
290	>	}
291	>
292	>	static void diskio_stat_init(sg_disk_io_stats *d) {
293		d->disk_name = NULL;
294		}
295
296	<	static void diskio_stat_destroy(diskio_stat_t *d) {
296	>	static void diskio_stat_destroy(sg_disk_io_stats *d) {
297		free(d->disk_name);
298		}
299
300	<	VECTOR_DECLARE_STATIC(diskio_stats, diskio_stat_t, 10,
301	<	diskio_stat_init, diskio_stat_destroy);
300	>	VECTOR_DECLARE_STATIC(diskio_stats, sg_disk_io_stats, 10,
301	>	diskio_stat_init, diskio_stat_destroy);
302
303		#ifdef LINUX
304		typedef struct {
#	Line 283 | Line 307 | typedef struct {
307		} partition;
308		#endif
309
310	<	diskio_stat_t *get_diskio_stats(int *entries){
310	>	sg_disk_io_stats *sg_get_disk_io_stats(int *entries){
311		int num_diskio;
312		#ifndef LINUX
313	<	diskio_stat_t *diskio_stats_ptr;
313	>	sg_disk_io_stats *diskio_stats_ptr;
314		#endif
315
316	+	#ifdef HPUX
317	+	long long rbytes = 0, wbytes = 0;
318	+	struct dirent *dinfo = NULL;
319	+	struct stat lstatinfo;
320	+	struct pst_diskinfo pstat_diskinfo[DISK_BATCH];
321	+	char fullpathbuf[1024] = {0};
322	+	dev_t diskid;
323	+	DIR *dh = NULL;
324	+	int diskidx = 0;
325	+	int num, i;
326	+	#endif
327		#ifdef SOLARIS
328	<	kstat_ctl_t *kc;
329	<	kstat_t *ksp;
328	>	kstat_ctl_t *kc;
329	>	kstat_t *ksp;
330		kstat_io_t kios;
331		#endif
332		#ifdef LINUX
#	Line 299 | Line 334 | diskio_stat_t *get_diskio_stats(int *entries){
334		char *line_ptr;
335		int major, minor;
336		int has_pp_stats = 1;
337	<	static partition *parts = NULL;
303	<	static int alloc_parts = 0;
337	>	VECTOR_DECLARE_STATIC(parts, partition, 16, NULL, NULL);
338		int i, n;
339		time_t now;
340		const char *format;
#	Line 337 | Line 371 | diskio_stat_t *get_diskio_stats(int *entries){
371
372		num_diskio=0;
373
374	+	#ifdef HPUX
375	+	while (1) {
376	+	num = pstat_getdisk(pstat_diskinfo, sizeof pstat_diskinfo[0],
377	+	DISK_BATCH, diskidx);
378	+	if (num == -1) {
379	+	sg_set_error_with_errno(SG_ERROR_PSTAT,
380	+	"pstat_getdisk");
381	+	return NULL;
382	+	} else if (num == 0) {
383	+	break;
384	+	}
385	+
386	+	for (i = 0; i < num; i++) {
387	+	struct pst_diskinfo *di = &pstat_diskinfo[i];
388	+
389	+	/* Skip "disabled" disks. */
390	+	if (di->psd_status == 0) {
391	+	continue;
392	+	}
393	+
394	+	/* We can't seperate the reads from the writes, we'll
395	+	* just give the same to each. (This value is in
396	+	* 64-byte chunks according to the pstat header file,
397	+	* and can wrap to be negative.)
398	+	*/
399	+	rbytes = wbytes = ((unsigned long) di->psd_dkwds) * 64LL;
400	+
401	+	/* Skip unused disks. */
402	+	if (rbytes == 0 && wbytes == 0) {
403	+	continue;
404	+	}
405	+
406	+	if (VECTOR_RESIZE(diskio_stats, num_diskio + 1) < 0) {
407	+	return NULL;
408	+	}
409	+
410	+	diskio_stats_ptr = diskio_stats + num_diskio;
411	+
412	+	diskio_stats_ptr->read_bytes = rbytes;
413	+	diskio_stats_ptr->write_bytes = wbytes;
414	+
415	+	diskio_stats_ptr->systime = time(NULL);
416	+
417	+	num_diskio++;
418	+
419	+	/* FIXME This should use a static cache, like the Linux
420	+	* code below. */
421	+	if (diskio_stats_ptr->disk_name == NULL) {
422	+	dh = opendir("/dev/dsk");
423	+	if (dh == NULL) {
424	+	continue;
425	+	}
426	+
427	+	diskid = (di->psd_dev.psd_major << 24) | di->psd_dev.psd_minor;
428	+	while (1) {
429	+	dinfo = readdir(dh);
430	+	if (dinfo == NULL) {
431	+	break;
432	+	}
433	+	snprintf(fullpathbuf, sizeof(fullpathbuf), "/dev/dsk/%s", dinfo->d_name);
434	+	if (lstat(fullpathbuf, &lstatinfo) < 0) {
435	+	continue;
436	+	}
437	+
438	+	if (lstatinfo.st_rdev == diskid) {
439	+	if (sg_update_string(&diskio_stats_ptr->disk_name, dinfo->d_name) < 0) {
440	+	return NULL;
441	+	}
442	+	break;
443	+	}
444	+	}
445	+	closedir(dh);
446	+
447	+	if (diskio_stats_ptr->disk_name == NULL) {
448	+	if (sg_update_string(&diskio_stats_ptr->disk_name, di->psd_hw_path.psh_name) < 0) {
449	+	return NULL;
450	+	}
451	+	}
452	+	}
453	+	}
454	+	diskidx = pstat_diskinfo[num - 1].psd_idx + 1;
455	+	}
456	+	#endif
457		#ifdef OPENBSD
458		mib[0] = CTL_HW;
459		mib[1] = HW_DISKCOUNT;
460
461		size = sizeof(diskcount);
462		if (sysctl(mib, MIBSIZE, &diskcount, &size, NULL, 0) < 0) {
463	+	sg_set_error_with_errno(SG_ERROR_SYSCTL, "CTL_HW.HW_DISKCOUNT");
464		return NULL;
465		}
466
#	Line 350 | Line 468 | diskio_stat_t *get_diskio_stats(int *entries){
468		mib[1] = HW_DISKNAMES;
469
470		if (sysctl(mib, MIBSIZE, NULL, &size, NULL, 0) < 0) {
471	+	sg_set_error_with_errno(SG_ERROR_SYSCTL, "CTL_HW.HW_DISKNAMES");
472		return NULL;
473		}
474
475	<	disknames = malloc(size);
475	>	disknames = sg_malloc(size);
476		if (disknames == NULL) {
477		return NULL;
478		}
479
480		if (sysctl(mib, MIBSIZE, disknames, &size, NULL, 0) < 0) {
481	+	sg_set_error_with_errno(SG_ERROR_SYSCTL, "CTL_HW.HW_DISKNAMES");
482		return NULL;
483		}
484
485	<	dk_name = calloc(diskcount, sizeof(char *));
485	>	dk_name = sg_malloc(diskcount * sizeof(char *));
486		bufpp = disknames;
487		for (i = 0; i < diskcount && (name = strsep(&bufpp, ",")) != NULL; i++) {
488		dk_name[i] = name;
#	Line 377 | Line 497 | diskio_stat_t *get_diskio_stats(int *entries){
497		#endif
498
499		if (sysctl(mib, MIBSIZE, NULL, &size, NULL, 0) < 0) {
500	+	sg_set_error_with_errno(SG_ERROR_SYSCTL, "CTL_HW.HW_DISKSTATS");
501		return NULL;
502		}
503
#	Line 386 | Line 507 | diskio_stat_t *get_diskio_stats(int *entries){
507		num_disks = size / sizeof(struct diskstats);
508		#endif
509
510	<	stats = malloc(size);
510	>	stats = sg_malloc(size);
511		if (stats == NULL) {
512		return NULL;
513		}
514
515		if (sysctl(mib, MIBSIZE, stats, &size, NULL, 0) < 0) {
516	+	sg_set_error_with_errno(SG_ERROR_SYSCTL, "CTL_HW.HW_DISKSTATS");
517		return NULL;
518		}
519
520		for (i = 0; i < num_disks; i++) {
521	+	const char *name;
522		u_int64_t rbytes, wbytes;
523
524		#ifdef NETBSD
#	Line 403 | Line 526 | diskio_stat_t *get_diskio_stats(int *entries){
526		rbytes = stats[i].dk_rbytes;
527		wbytes = stats[i].dk_wbytes;
528		#else
529	<	/* Before 1.7, NetBSD merged reads and writes. */
529	>	/* Before 2.0, NetBSD merged reads and writes. */
530		rbytes = wbytes = stats[i].dk_bytes;
531		#endif
532		#else
533	+	#ifdef HAVE_DS_RBYTES
534	+	rbytes = stats[i].ds_rbytes;
535	+	wbytes = stats[i].ds_wbytes;
536	+	#else
537	+	/* Before 3.5, OpenBSD merged reads and writes */
538		rbytes = wbytes = stats[i].ds_bytes;
539		#endif
540	+	#endif
541
542		/* Don't keep stats for disks that have never been used. */
543		if (rbytes == 0 && wbytes == 0) {
#	Line 422 | Line 551 | diskio_stat_t *get_diskio_stats(int *entries){
551
552		diskio_stats_ptr->read_bytes = rbytes;
553		diskio_stats_ptr->write_bytes = wbytes;
425	–	if (diskio_stats_ptr->disk_name != NULL) {
426	–	free(diskio_stats_ptr->disk_name);
427	–	}
554		#ifdef NETBSD
555	<	diskio_stats_ptr->disk_name = strdup(stats[i].dk_name);
555	>	name = stats[i].dk_name;
556		#else
557	<	diskio_stats_ptr->disk_name = strdup(dk_name[i]);
557	>	name = dk_name[i];
558		#endif
559	+	if (sg_update_string(&diskio_stats_ptr->disk_name, name) < 0) {
560	+	return NULL;
561	+	}
562		diskio_stats_ptr->systime = time(NULL);
563
564		num_diskio++;
#	Line 444 | Line 573 | diskio_stat_t *get_diskio_stats(int *entries){
573
574		#if defined(FREEBSD) || defined(DFBSD)
575		if (!stats_init) {
576	<	stats.dinfo=malloc(sizeof(struct devinfo));
576	>	stats.dinfo=sg_malloc(sizeof(struct devinfo));
577		if(stats.dinfo==NULL) return NULL;
578		bzero(stats.dinfo, sizeof(struct devinfo));
579		stats_init = 1;
580		}
581		#ifdef FREEBSD5
582	<	if ((devstat_getdevs(NULL, &stats)) < 0) return NULL;
582	>	if ((devstat_getdevs(NULL, &stats)) < 0) {
583	>	/* FIXME devstat functions return a string error in
584	>	devstat_errbuf */
585	>	sg_set_error(SG_ERROR_DEVSTAT_GETDEVS, NULL);
586	>	return NULL;
587	>	}
588		/* Not aware of a get all devices, so i said 999. If we ever
589		* find a machine with more than 999 disks, then i'll change
590		* this number :)
591		*/
592	<	if (devstat_selectdevs(&dev_sel, &n_selected, &n_selections, &sel_gen, stats.dinfo->generation, stats.dinfo->devices, stats.dinfo->numdevs, NULL, 0, NULL, 0, DS_SELECT_ONLY, 999, 1) < 0) return NULL;
592	>	if (devstat_selectdevs(&dev_sel, &n_selected, &n_selections, &sel_gen, stats.dinfo->generation, stats.dinfo->devices, stats.dinfo->numdevs, NULL, 0, NULL, 0, DS_SELECT_ONLY, 999, 1) < 0) {
593	>	sg_set_error(SG_ERROR_DEVSTAT_SELECTDEVS, NULL);
594	>	return NULL;
595	>	}
596		#else
597	<	if ((getdevs(&stats)) < 0) return NULL;
597	>	if ((getdevs(&stats)) < 0) {
598	>	sg_set_error(SG_ERROR_DEVSTAT_GETDEVS, NULL);
599	>	return NULL;
600	>	}
601		/* Not aware of a get all devices, so i said 999. If we ever
602		* find a machine with more than 999 disks, then i'll change
603		* this number :)
604		*/
605	<	if (selectdevs(&dev_sel, &n_selected, &n_selections, &sel_gen, stats.dinfo->generation, stats.dinfo->devices, stats.dinfo->numdevs, NULL, 0, NULL, 0, DS_SELECT_ONLY, 999, 1) < 0) return NULL;
605	>	if (selectdevs(&dev_sel, &n_selected, &n_selections, &sel_gen, stats.dinfo->generation, stats.dinfo->devices, stats.dinfo->numdevs, NULL, 0, NULL, 0, DS_SELECT_ONLY, 999, 1) < 0) {
606	>	sg_set_error(SG_ERROR_DEVSTAT_SELECTDEVS, NULL);
607	>	return NULL;
608	>	}
609		#endif
610
611		for(counter=0;counter<stats.dinfo->numdevs;counter++){
#	Line 491 | Line 634 | diskio_stat_t *get_diskio_stats(int *entries){
634		diskio_stats_ptr->write_bytes=dev_ptr->bytes_written;
635		#endif
636		if(diskio_stats_ptr->disk_name!=NULL) free(diskio_stats_ptr->disk_name);
637	<	asprintf((&diskio_stats_ptr->disk_name), "%s%d", dev_ptr->device_name, dev_ptr->unit_number);
637	>	if (asprintf((&diskio_stats_ptr->disk_name), "%s%d", dev_ptr->device_name, dev_ptr->unit_number) == -1) {
638	>	sg_set_error_with_errno(SG_ERROR_ASPRINTF, NULL);
639	>	return NULL;
640	>	}
641		diskio_stats_ptr->systime=time(NULL);
642
643		num_diskio++;
#	Line 501 | Line 647 | diskio_stat_t *get_diskio_stats(int *entries){
647		#endif
648		#ifdef SOLARIS
649		if ((kc = kstat_open()) == NULL) {
650	<	return NULL;
651	<	}
650	>	sg_set_error(SG_ERROR_KSTAT_OPEN, NULL);
651	>	return NULL;
652	>	}
653
654		for (ksp = kc->kc_chain; ksp; ksp = ksp->ks_next) {
655	<	if (!strcmp(ksp->ks_class, "disk")) {
655	>	if (!strcmp(ksp->ks_class, "disk")) {
656
657		if(ksp->ks_type != KSTAT_TYPE_IO) continue;
658		/* We dont want metadevices appearins as num_diskio */
659		if(strcmp(ksp->ks_module, "md")==0) continue;
660	<	if((kstat_read(kc, ksp, &kios))==-1){
660	>	if((kstat_read(kc, ksp, &kios))==-1){
661		}
662
663		if (VECTOR_RESIZE(diskio_stats, num_diskio + 1) < 0) {
#	Line 520 | Line 667 | diskio_stat_t *get_diskio_stats(int *entries){
667		diskio_stats_ptr=diskio_stats+num_diskio;
668
669		diskio_stats_ptr->read_bytes=kios.nread;
523	–
670		diskio_stats_ptr->write_bytes=kios.nwritten;
671	<
672	<	if(diskio_stats_ptr->disk_name!=NULL) free(diskio_stats_ptr->disk_name);
673	<
674	<	diskio_stats_ptr->disk_name=strdup((char *) get_svr_from_bsd(ksp->ks_name));
671	>	if (sg_update_string(&diskio_stats_ptr->disk_name,
672	>	sg_get_svr_from_bsd(ksp->ks_name)) < 0) {
673	>	return NULL;
674	>	}
675		diskio_stats_ptr->systime=time(NULL);
676	+
677		num_diskio++;
678		}
679		}
#	Line 552 | Line 699 | diskio_stat_t *get_diskio_stats(int *entries){
699		if (f == NULL) goto out;
700		now = time(NULL);
701
702	<	while ((line_ptr = f_read_line(f, "")) != NULL) {
702	>	while ((line_ptr = sg_f_read_line(f, "")) != NULL) {
703		char name[100];
704		char *s;
705		long long rsect, wsect;
#	Line 577 | Line 724 | diskio_stat_t *get_diskio_stats(int *entries){
724		if (VECTOR_RESIZE(diskio_stats, n + 1) < 0) {
725		goto out;
726		}
727	<	if (n >= alloc_parts) {
728	<	alloc_parts += 16;
582	<	parts = realloc(parts, alloc_parts * sizeof *parts);
583	<	if (parts == NULL) {
584	<	alloc_parts = 0;
585	<	goto out;
586	<	}
727	>	if (VECTOR_RESIZE(parts, n + 1) < 0) {
728	>	goto out;
729		}
730
731	<	if (diskio_stats[n].disk_name != NULL)
732	<	free(diskio_stats[n].disk_name);
733	<	diskio_stats[n].disk_name = strdup(name);
731	>	if (sg_update_string(&diskio_stats[n].disk_name, name) < 0) {
732	>	goto out;
733	>	}
734		diskio_stats[n].read_bytes = rsect * 512;
735		diskio_stats[n].write_bytes = wsect * 512;
736		diskio_stats[n].systime = now;
#	Line 610 | Line 752 | diskio_stat_t *get_diskio_stats(int *entries){
752		if (f == NULL) goto out;
753		now = time(NULL);
754
755	<	line_ptr = f_read_line(f, "disk_io:");
755	>	line_ptr = sg_f_read_line(f, "disk_io:");
756		if (line_ptr == NULL) goto out;
757
758		while((line_ptr=strchr(line_ptr, ' '))!=NULL){
#	Line 674 | Line 816 | out:
816		#endif
817
818		#ifdef CYGWIN
819	+	sg_set_error(SG_ERROR_UNSUPPORTED, "Cygwin");
820		return NULL;
821		#endif
822
#	Line 682 | Line 825 | out:
825		return diskio_stats;
826		}
827
828	<	diskio_stat_t *get_diskio_stats_diff(int *entries){
829	<	VECTOR_DECLARE_STATIC(diff, diskio_stat_t, 1,
830	<	diskio_stat_init, diskio_stat_destroy);
831	<	diskio_stat_t *src = NULL, *dest;
828	>	sg_disk_io_stats *sg_get_disk_io_stats_diff(int *entries){
829	>	VECTOR_DECLARE_STATIC(diff, sg_disk_io_stats, 1,
830	>	diskio_stat_init, diskio_stat_destroy);
831	>	sg_disk_io_stats *src = NULL, *dest;
832		int i, j, diff_count, new_count;
833
834		if (diskio_stats == NULL) {
835		/* No previous stats, so we can't calculate a difference. */
836	<	return get_diskio_stats(entries);
836	>	return sg_get_disk_io_stats(entries);
837		}
838
839		/* Resize the results array to match the previous stats. */
#	Line 704 | Line 847 | diskio_stat_t *get_diskio_stats_diff(int *entries){
847		src = &diskio_stats[i];
848		dest = &diff[i];
849
850	<	if (dest->disk_name != NULL) {
851	<	free(dest->disk_name);
850	>	if (sg_update_string(&dest->disk_name, src->disk_name) < 0) {
851	>	return NULL;
852		}
710	–	dest->disk_name = strdup(src->disk_name);
853		dest->read_bytes = src->read_bytes;
854		dest->write_bytes = src->write_bytes;
855		dest->systime = src->systime;
856		}
857
858		/* Get a new set of stats. */
859	<	if (get_diskio_stats(&new_count) == NULL) {
859	>	if (sg_get_disk_io_stats(&new_count) == NULL) {
860		return NULL;
861		}
862
#	Line 745 | Line 887 | diskio_stat_t *get_diskio_stats_diff(int *entries){
887
888		*entries = diff_count;
889		return diff;
890	+	}
891	+
892	+	int sg_disk_io_compare_name(const void *va, const void *vb) {
893	+	const sg_disk_io_stats *a = (const sg_disk_io_stats *)va;
894	+	const sg_disk_io_stats *b = (const sg_disk_io_stats *)vb;
895	+
896	+	return strcmp(a->disk_name, b->disk_name);
897		}
898

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines