--- web/cgi-bin/docs.cgi 2000/10/25 23:56:27 1.1 +++ web/cgi-bin/docs.cgi 2004/03/25 22:48:47 1.12 @@ -1,94 +1,144 @@ #!/usr/bin/perl -w -#------------------------------------------------------------ -# docs.cgi -# -# Web-based text file viewer. -# Copyright Paul Mutton, 2000. -#------------------------------------------------------------ - use strict; use CGI; $| = 1; # Settings -my ($left) = "../left.inc" ; -my ($title) = "../title.inc"; -my ($bottom) = "../bottom.inc"; +my ($incdir) = "../htdocs"; +# Include files +my ($doctype) = "$incdir/doctype.inc"; +my ($style) = "$incdir/style.inc"; +my ($header) = "$incdir/header.inc"; +my ($footer) = "$incdir/footer.inc"; +my ($menu) = "$incdir/menu-static.inc" ; my ($query) = new CGI; -my ($doci) = ($query->param('doc') =~ /^\s*(.*?\.txt)\s*$/); -my ($doc) = "../documentation/$doci"; -print "content-type: text/html\n\n"; +# Note filenames may only have one dot in them, in the ".txt". +# This prevents malicious users using "../" to view files. +my ($doc) = ($query->param('doc') =~ /^\s*([^\.]*?\.txt)\s*$/); -print <<"END"; -<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> +# This should be application/xhtml+xml +print "Content-type: text/html\n\n"; -<!-- - docs.cgi - Web-based text file viewer and formatter. - Created by pjm2 19/10/2000 - Last modified 19/10/2000 ---> +unless (defined $doc) { + print "The link to this page was broken - it must specify a .txt file."; + exit; +} -<html> +# Prevent hackers from supplying a malformed document string. +# I.e. only allow normal characters, slashes and dots. +unless ($doc =~ /^[a-zA-Z_\-0-9\.\/]+$/) { + print "Malformed request."; + exit; +} +$doc = "../htdocs/documentation/".$doc; -<head> - <title>The i-scream Project Documentation Viewer</title> - <meta name="description" content="The i-scream Project is a central monitoring system for Unix, Linux and NT servers."> - <meta name="keywords" content="i-scream, project, central monitoring system, unix, linux, nt, server, alert"> - <meta name="generator" content="notepad on acid, aye."> -</head> +my($docname) = $doc =~ /\/([^\/]+)$/; -<body bgcolor="#ffffff" link="#0000ff" alink="#3333cc" vlink="#3333cc" text="#000066"> +&print_html($doctype); -<table border="0" cellpadding="2" cellspacing="2"> - <tr> - <td valign="top"> +print <<"END"; + + <head> + <title> + i-scream plain text documentation viewer + </title> END -&print_file($left); +&print_html($style); print <<"END"; - </td> - <td valign="top"> + </head> + <body> + <div id="container"> + <div id="main"> END -&print_file($title); +&print_html($header); -print "<PRE>\n"; +print <<"END"; + + <div id="contents"> + <h1 class="top"> + i-scream documentation viewer + </h1> + <h2> + $docname + </h2> +END + &print_file($doc); -print "</PRE>\n"; -&print_file($bottom); +print <<"END"; + </div> +END + +&print_html($footer); + print <<"END"; - </td> - </tr> -</table> + </div> +END -</body> +&print_html($menu); +print <<"END"; + + </div> + </body> </html> END exit 0; -sub print_file ($) { +# Print a file, whilst escaping HTML: - +sub print_file { +my ($urls) = '(' . join ('|', qw{ + http + telnet + gopher + file + wais + ftp + } ) + . ')'; + + my ($ltrs) = '\w'; + my ($gunk) = '/#~:.?+=&%@!\-'; + my ($punc) = '.:?\-'; + my ($any) = "${ltrs}${gunk}${punc}"; my ($filename) = @_; - print `cat $filename`; + if(open(FILE, $filename)) { + print " <pre>\n"; + # Use $_ implicitly throughout. + while (<FILE>) { + # Must do the next line first! + s/&/&/g; + s/</</g; + s/>/>/g; + s/"/"/g; + s/\b($urls:[$any]+?)(?=[$punc]*[^$any]|$)/<a href="$1">$1<\/a>/igox; + print; + } + print "\n</pre>"; + } + else { + print "Failed to open $docname."; + } } -sub print_file_old ($) { +# Print the contents of a file containing html +sub print_html ($) { my ($filename) = @_; - open(FILE, $filename) or die "Cannot open $filename: $!\n"; - while (my ($line) = <FILE>) { - print $line; + open(FILE, $filename); + while(<FILE>) { + print; } + close FILE; } -